Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Side by Side Diff: Source/core/dom/Element.cpp

Issue 1173283002: Move some Element specific code from Node::detach to Element::detach. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1485 matching lines...) Expand 10 before | Expand all | Expand 10 after
1496 } 1496 }
1497 elementAnimations->clearBaseComputedStyle(); 1497 elementAnimations->clearBaseComputedStyle();
1498 } 1498 }
1499 1499
1500 if (ElementShadow* shadow = data->shadow()) 1500 if (ElementShadow* shadow = data->shadow())
1501 shadow->detach(context); 1501 shadow->detach(context);
1502 } 1502 }
1503 1503
1504 ContainerNode::detach(context); 1504 ContainerNode::detach(context);
1505 1505
1506 ASSERT(needsAttach()); 1506 if (!context.performingReattach && isUserActionElement()) {
1507 if (hovered())
1508 document().hoveredNodeDetached(*this);
1509 if (inActiveChain())
1510 document().activeChainNodeDetached(*this);
1511 document().userActionElements().didDetach(*this);
1512 }
1513
1514 document().styleEngine().styleInvalidator().clearInvalidation(*this);
1515
1507 if (svgFilterNeedsLayerUpdate()) 1516 if (svgFilterNeedsLayerUpdate())
1508 document().unscheduleSVGFilterLayerUpdateHack(*this); 1517 document().unscheduleSVGFilterLayerUpdateHack(*this);
1518
1519 ASSERT(needsAttach());
1509 } 1520 }
1510 1521
1511 bool Element::pseudoStyleCacheIsInvalid(const ComputedStyle* currentStyle, Compu tedStyle* newStyle) 1522 bool Element::pseudoStyleCacheIsInvalid(const ComputedStyle* currentStyle, Compu tedStyle* newStyle)
1512 { 1523 {
1513 ASSERT(currentStyle == computedStyle()); 1524 ASSERT(currentStyle == computedStyle());
1514 ASSERT(layoutObject()); 1525 ASSERT(layoutObject());
1515 1526
1516 if (!currentStyle) 1527 if (!currentStyle)
1517 return false; 1528 return false;
1518 1529
(...skipping 1869 matching lines...) Expand 10 before | Expand all | Expand 10 after
3388 { 3399 {
3389 #if ENABLE(OILPAN) 3400 #if ENABLE(OILPAN)
3390 if (hasRareData()) 3401 if (hasRareData())
3391 visitor->trace(elementRareData()); 3402 visitor->trace(elementRareData());
3392 visitor->trace(m_elementData); 3403 visitor->trace(m_elementData);
3393 #endif 3404 #endif
3394 ContainerNode::trace(visitor); 3405 ContainerNode::trace(visitor);
3395 } 3406 }
3396 3407
3397 } // namespace blink 3408 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698