Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1173283002: Move some Element specific code from Node::detach to Element::detach. (Closed)

Created:
4 years, 10 months ago by esprehn
Modified:
4 years, 10 months ago
Reviewers:
Timothy Loh, dglazkov, rune, ojan
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move some Element specific code from Node::detach to Element::detach. This code is specific to Elements, so there's no reason to run it for every Text or ShadowRoot in the page. R=timloh@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -37 lines) Patch
M Source/core/css/invalidation/StyleInvalidator.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/css/invalidation/StyleInvalidator.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/dom/Document.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +7 lines, -8 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +12 lines, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 2 chunks +1 line, -16 lines 0 comments Download
M Source/core/dom/UserActionElementSet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/UserActionElementSet.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173283002/1
4 years, 10 months ago (2015-06-11 17:28:26 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-11 18:53:46 UTC) #5
dglazkov
lgtm
4 years, 10 months ago (2015-06-11 23:03:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173283002/1
4 years, 10 months ago (2015-06-11 23:03:28 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 23:07:46 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196979

Powered by Google App Engine
This is Rietveld 408576698