content/browser/tracing/trace_message_filter.h - Issue 1173263004: [tracing] Send unique tracing process id for cross-process memory dumps identification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/trace_message_filter.h

Issue 1173263004: [tracing] Send unique tracing process id for cross-process memory dumps identification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/memory_dump_manager.h ('K') | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/browser/tracing/trace_message_filter.cc » ('j') | content/browser/tracing/trace_message_filter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/tracing/trace_message_filter.h

diff --git a/content/browser/tracing/trace_message_filter.h b/content/browser/tracing/trace_message_filter.h

index 0d1f05cf8b836a6e2bc946e0d5241e63fb2e2946..4f0fa9371d226b2fc667c9a476cff44c8bd768db 100644

--- a/content/browser/tracing/trace_message_filter.h

+++ b/content/browser/tracing/trace_message_filter.h

@@ -19,7 +19,7 @@ namespace content {

// See also: child_trace_message_filter.h

class TraceMessageFilter : public BrowserMessageFilter {

public:

- TraceMessageFilter();

+ explicit TraceMessageFilter(int child_process_id);

// BrowserMessageFilter implementation.

void OnChannelClosing() override;

@@ -60,6 +60,9 @@ class TraceMessageFilter : public BrowserMessageFilter {

// ChildTraceMessageFilter exists:

bool has_child_;

+ // Hash of id of the child process.

+ int tracing_process_id_;

// Awaiting ack for previously sent SendEndTracing

bool is_awaiting_end_ack_;

// Awaiting ack for previously sent SendCaptureMonitoringSnapshot