[tracing] Send unique tracing process id for cross-process memory dumps identification.

base/trace_event/memory_allocator_dump_guid.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/trace_event/memory_allocator_dump_guid.h"
 
 #include "base/format_macros.h"
 #include "base/hash.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 
 namespace base {
 namespace trace_event {
 
+namespace {
+int g_unique_child_process_id = MemoryAllocatorDumpGuid::kInvalidChildProcessId;
+
+uint64 ExpandChildProcessIdAndHash(std::string guid_str) {

[dcheng, 2015/06/20 00:36:27]

const std::string&

[Primiano Tucci (use gerrit), 2015/06/20 12:32:31]

Note: the string is mangled below. If he passes a const& string, than he'll need
to create a copy anyways to mangle it. is it worth it the extra line?

[ssid, 2015/06/20 13:07:24]

Yes, instead of creating a copy, i passed std::string.

+  const char kReplaceChildIdStr[] = "$$";
+  size_t pos = guid_str.find(kReplaceChildIdStr);
+  if (pos != std::string::npos) {
+    DCHECK_NE(g_unique_child_process_id,
+              MemoryAllocatorDumpGuid::kInvalidChildProcessId);
+    guid_str.replace(pos, sizeof(kReplaceChildIdStr) - 1,
+                     IntToString(g_unique_child_process_id));
+  }
+  return Hash(guid_str);
+}
+}  // namespace
+
 MemoryAllocatorDumpGuid::MemoryAllocatorDumpGuid(uint64 guid) : guid_(guid) {
 }
 
 MemoryAllocatorDumpGuid::MemoryAllocatorDumpGuid()
     : MemoryAllocatorDumpGuid(0u) {
 }
 
 MemoryAllocatorDumpGuid::MemoryAllocatorDumpGuid(const std::string& guid_str)
-    : MemoryAllocatorDumpGuid(Hash(guid_str)) {
+    : MemoryAllocatorDumpGuid(ExpandChildProcessIdAndHash(guid_str)) {
+}
+
+// static
+void MemoryAllocatorDumpGuid::SetUniqueChildProcessId(int child_process_id) {
+  DCHECK(g_unique_child_process_id == kInvalidChildProcessId ||
+         child_process_id == kInvalidChildProcessId);
+  g_unique_child_process_id = child_process_id;
 }
 
 std::string MemoryAllocatorDumpGuid::ToString() const {
   return StringPrintf("%" PRIx64, guid_);
 }
 
 }  // namespace trace_event
 }  // namespace base