Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1173253006: Revert of Serializer: support all alignment kinds. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Serializer: support all alignment kinds. (patchset #3 id:40001 of https://codereview.chromium.org/1179873003/) Reason for revert: [Sheriff] Breaks arm debug compile: http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/4308 Original issue's description: > Serializer: support all alignment kinds. > > We use an alignment prefix for unusual alignment kinds (not kWordAligned). > This will cause new objects to be aligned in ReadObject, and back references > to be aligned to skip padding. > > The motivation to change the undefined next sentinel in WeakCell is this: > When the deserializer aligns an object, it requires filler maps to already > exist to create filler objects as padding. However, deserializing the > filler map leads to deserializing NaN, which as heap number is aligned: > filler map > meta map > weak cell cache > undefined > NaN > If we use the-hole instead of undefined as sentinel, it works. > > R=jochen@chromium.org,bbudge@chromium.org > BUG=v8:4178 > LOG=N > > Committed: https://crrev.com/2146ab75387d47eef6582bd8c2d0cfc6c42b68b6 > Cr-Commit-Position: refs/heads/master@{#29044} TBR=jochen@chromium.org,bbudge@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4178 Committed: https://crrev.com/33ae0e6762011e80172b84054a0a90e3b0822772 Cr-Commit-Position: refs/heads/master@{#29045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -101 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/snapshot/serialize.h View 5 chunks +6 lines, -18 lines 0 comments Download
M src/snapshot/serialize.cc View 10 chunks +57 lines, -71 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Serializer: support all alignment kinds.
5 years, 6 months ago (2015-06-16 10:18:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173253006/1
5 years, 6 months ago (2015-06-16 10:18:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 10:18:39 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 10:18:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33ae0e6762011e80172b84054a0a90e3b0822772
Cr-Commit-Position: refs/heads/master@{#29045}

Powered by Google App Engine
This is Rietveld 408576698