Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1173253004: [turbofan] Ensure lazy bailout point in exception handler. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ensure lazy bailout point in exception handler. This ensures there is a lazy bailout point at the entry of every exception handler so that deoptimized code is not re-entered through caught exceptions. R=jarin@chromium.org TEST=cctest/test-run-deopt/DeoptExceptionHandler Committed: https://crrev.com/3161cb550c8c44560ed7f1ee70f2cc989a8b32d8 Cr-Commit-Position: refs/heads/master@{#29061}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Fix interference with stack limit. #

Patch Set 4 : Ensure space for lazy deopt. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -28 lines) Patch
M src/ast.h View 1 chunk +16 lines, -1 line 0 comments Download
M src/ast-numbering.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 2 chunks +14 lines, -4 lines 0 comments Download
M src/compiler/code-generator.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/instruction.h View 1 2 3 3 chunks +3 lines, -1 line 0 comments Download
M src/compiler/instruction.cc View 1 2 3 3 chunks +5 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-deopt.cc View 1 chunk +59 lines, -16 lines 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-12 11:25:59 UTC) #1
Michael Starzinger
PTAL. This in finally ready for a review. Benedikt: PTAL at the backend implementation. Jaro: ...
5 years, 6 months ago (2015-06-16 11:56:49 UTC) #3
Jarin
lgtm
5 years, 6 months ago (2015-06-16 12:05:01 UTC) #4
Benedikt Meurer
LGTM.
5 years, 6 months ago (2015-06-17 03:22:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173253004/60001
5 years, 6 months ago (2015-06-17 04:58:49 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-17 05:40:34 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 05:40:49 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3161cb550c8c44560ed7f1ee70f2cc989a8b32d8
Cr-Commit-Position: refs/heads/master@{#29061}

Powered by Google App Engine
This is Rietveld 408576698