Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: public/platform/WebMemoryAllocatorDump.h

Issue 1173253002: [tracing] Clean up the MemoryInfra API surface (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebMemoryAllocatorDump.h
diff --git a/public/platform/WebMemoryAllocatorDump.h b/public/platform/WebMemoryAllocatorDump.h
index 91136f19852769e96912b0a042f64cb9a48a40ed..3f8bf8da3087c9a58c1e90c3048310a161fa4104 100644
--- a/public/platform/WebMemoryAllocatorDump.h
+++ b/public/platform/WebMemoryAllocatorDump.h
@@ -19,14 +19,19 @@ public:
// Adds a scalar attribute to the dump.
// Arguments:
// name: name of the attribute. Typical names, emitted by most allocators
- // dump providers are: "outer_size", "inner_size", "objects_count".
+ // dump providers are: "size" and "objects_count".
// units: the units for the attribute. Gives a hint to the trace-viewer UI
// about the semantics of the attribute.
// Currently supported values are "bytes" and "objects".
// value: the value of the attribute.
- virtual void AddScalar(const WebString& name, const char* units, uint64_t value) { BLINK_ASSERT_NOT_REACHED(); }
- virtual void AddScalarF(const WebString& name, const char* units, double value) { BLINK_ASSERT_NOT_REACHED(); }
- virtual void AddString(const WebString& name, const char* units, const WebString& value) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void AddScalar(const char* name, const char* units, uint64_t value) { }
+ virtual void AddScalarF(const char* name, const char* units, double value) { }
+ virtual void AddString(const char* name, const char* units, const WebString& value) { }
+
+ // TODO(primiano): these below will go away soon, required only to handle a multisided patch.
+ virtual void AddScalar(const WebString& name, const char* units, uint64_t value) { }
+ virtual void AddScalarF(const WebString& name, const char* units, double value) { }
+ virtual void AddString(const WebString& name, const char* units, const WebString& value) { }
};
} // namespace blink
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698