Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(29)

Issue 1173253002: [tracing] Clean up the MemoryInfra API surface (1/3) (Closed)

Created:
4 years, 10 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 10 months ago
Reviewers:
pdr., Rick Byers
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[tracing] Clean up the MemoryInfra API surface (1/3) This patch simplifies the API surface of MemoryInfra switching attribute names from std::string to char*. The main goal is to make the dumping fast and predictable memory-wise. There is no point allowing the attribute names to be arbitrary strings (read non static "quoted" char* ptrs). That has the only effect of causing loads of copies and std::string ctors / dtors. This is part of a multisided dance: 1 In this CL, the new char* overloads are being defined, temporarily side by side with the old std::string ones. 2 Once Blink is rolled, chromium-side will switch from WebString -> char*. 3 Once landed, blink side can remove the WebString overloads. BUG=495628, 480500 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M public/platform/WebMemoryAllocatorDump.h View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Primiano Tucci (use gerrit)
Hello! I need to do some cleanup (crbug.com/495628) for motivations, and it will require a ...
4 years, 10 months ago (2015-06-11 00:48:01 UTC) #2
Rick Byers
lgtm
4 years, 10 months ago (2015-06-11 01:38:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173253002/1
4 years, 10 months ago (2015-06-11 01:38:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/66091)
4 years, 10 months ago (2015-06-11 02:20:41 UTC) #7
Rick Byers
On 2015/06/11 02:20:41, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 10 months ago (2015-06-11 02:51:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173253002/1
4 years, 10 months ago (2015-06-11 06:02:44 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 06:50:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196918

Powered by Google App Engine
This is Rietveld 408576698