Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1173233002: Separate out the raw (directly manipulating sky.view) examples from the rendering (using RenderObje… (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Separate out the raw (directly manipulating sky.view) examples from the rendering (using RenderObject et al) examples. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7f3da5d67d6184b15e10531825e09a6d743e1138

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-8 lines, -899 lines) Patch
D sky/examples/raw/borders.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D sky/examples/raw/interactive_flex.dart View 1 chunk +0 lines, -95 lines 0 comments Download
D sky/examples/raw/justify_content.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D sky/examples/raw/render_paragraph.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D sky/examples/raw/sector_layout.dart View 1 chunk +0 lines, -506 lines 0 comments Download
D sky/examples/raw/shadowed_box.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/examples/raw/touch_demo.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D sky/examples/raw/transform.dart View 1 chunk +0 lines, -27 lines 0 comments Download
A + sky/examples/rendering/borders.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/rendering/interactive_flex.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/rendering/justify_content.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/rendering/render_paragraph.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/rendering/sector_layout.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/rendering/shadowed_box.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/rendering/touch_demo.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/rendering/transform.dart View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-10 23:21:06 UTC) #2
Hixie
5 years, 6 months ago (2015-06-10 23:23:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f3da5d67d6184b15e10531825e09a6d743e1138 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698