Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 117323010: Redefine (u)int{8,16,32} as (u)int{8,16,32}_t. (Closed)

Created:
6 years, 11 months ago by viettrungluu
Modified:
6 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Redefine (u)int{8,16,32} as (u)int{8,16,32}_t. We can now do this since we have stdint.h everywhere. Leave the 64-bit types for now since they require more investigation. Delete schar, since it's unused in Chromium. R=brettw@chromium.org BUG=138542 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243143

Patch Set 1 #

Patch Set 2 : grrr #

Patch Set 3 : delete fixme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -32 lines) Patch
M base/basictypes.h View 1 2 2 chunks +20 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
WDYT? This makes the old-school basictypes.h types synonomous with the stdint.h types, with a few ...
6 years, 11 months ago (2014-01-04 05:06:16 UTC) #1
brettw
lgtm
6 years, 11 months ago (2014-01-04 21:35:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/117323010/130001
6 years, 11 months ago (2014-01-06 17:26:52 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 19:35:59 UTC) #4
Message was sent while issue was closed.
Change committed as 243143

Powered by Google App Engine
This is Rietveld 408576698