Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: Source/core/editing/StyledMarkupSerializer.cpp

Issue 1173223003: Refactoring: Remove addDisplayInline parameter of StyledMarkupAccumulator::appendElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: tkent's review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/StyledMarkupSerializer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/StyledMarkupSerializer.cpp
diff --git a/Source/core/editing/StyledMarkupSerializer.cpp b/Source/core/editing/StyledMarkupSerializer.cpp
index 504f1e95fe01b1f47623e00eea6c9a05dc836999..aba1d8fc7c0dce76e4fb4f464f188a1d845048cd 100644
--- a/Source/core/editing/StyledMarkupSerializer.cpp
+++ b/Source/core/editing/StyledMarkupSerializer.cpp
@@ -297,16 +297,30 @@ Node* StyledMarkupSerializer<Strategy>::traverseNodesForSerialization(Node* star
}
template<typename Strategy>
+bool StyledMarkupSerializer<Strategy>::needsInlineStyle(const Element& element)
+{
+ if (!element.isHTMLElement())
+ return false;
+ if (m_shouldAnnotate == AnnotateForInterchange)
+ return true;
+ return convertBlocksToInlines() && isBlock(&element);
+}
+
+template<typename Strategy>
void StyledMarkupSerializer<Strategy>::wrapWithNode(StyledMarkupAccumulator& accumulator, ContainerNode& node, PassRefPtrWillBeRawPtr<EditingStyle> style)
{
StringBuilder markup;
- if (node.isElementNode())
- accumulator.appendElement(markup, toElement(node), convertBlocksToInlines() && isBlock(&node), style);
- else
+ if (!node.isElementNode()) {
accumulator.appendStartMarkup(markup, node);
- accumulator.pushMarkup(markup.toString());
- if (!node.isElementNode())
+ accumulator.pushMarkup(markup.toString());
return;
+ }
+ Element& element = toElement(node);
+ if (accumulator.shouldApplyWrappingStyle(element) || needsInlineStyle(element))
+ accumulator.appendElementWithInlineStyle(markup, element, style);
+ else
+ accumulator.appendElement(markup, element);
+ accumulator.pushMarkup(markup.toString());
accumulator.appendEndTag(toElement(node));
}
« no previous file with comments | « Source/core/editing/StyledMarkupSerializer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698