Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(78)

Issue 1173223003: Refactoring: Remove addDisplayInline parameter of StyledMarkupAccumulator::appendElement (Closed)

Created:
4 years, 10 months ago by hajimehoshi
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-style_chromium.org, yosin_UTC9
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactoring: Remove addDisplayInline parameter of StyledMarkupAccumulator::appendElement This CL removes an boolean parameter |addDisplayInline| from StyledMarkupAccumulator::appendElement to improve the code health. |addDisplayInline| is used to determine whether an inline style is added to an element node, and this CL splits appendElement into appendElement and appendElementWithInlineStyle for the respective cases. BUG=n/a TEST=n/a; behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196934

Patch Set 1 #

Total comments: 2

Patch Set 2 : tkent's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -22 lines) Patch
M Source/core/editing/StyledMarkupAccumulator.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/editing/StyledMarkupAccumulator.cpp View 1 2 chunks +20 lines, -14 lines 0 comments Download
M Source/core/editing/StyledMarkupSerializer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/StyledMarkupSerializer.cpp View 1 chunk +19 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hajimehoshi
tkent: I created this CL with yosin@ in pair-programming, so please take a look.
4 years, 10 months ago (2015-06-11 08:31:46 UTC) #2
tkent
lgtm https://codereview.chromium.org/1173223003/diff/1/Source/core/editing/StyledMarkupAccumulator.cpp File Source/core/editing/StyledMarkupAccumulator.cpp (right): https://codereview.chromium.org/1173223003/diff/1/Source/core/editing/StyledMarkupAccumulator.cpp#newcode187 Source/core/editing/StyledMarkupAccumulator.cpp:187: void StyledMarkupAccumulator::appendElement(StringBuilder& out, Element& element) optional: Can we ...
4 years, 10 months ago (2015-06-11 08:46:09 UTC) #3
hajimehoshi
Thank you! https://codereview.chromium.org/1173223003/diff/1/Source/core/editing/StyledMarkupAccumulator.cpp File Source/core/editing/StyledMarkupAccumulator.cpp (right): https://codereview.chromium.org/1173223003/diff/1/Source/core/editing/StyledMarkupAccumulator.cpp#newcode187 Source/core/editing/StyledMarkupAccumulator.cpp:187: void StyledMarkupAccumulator::appendElement(StringBuilder& out, Element& element) On 2015/06/11 ...
4 years, 10 months ago (2015-06-11 08:56:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173223003/20001
4 years, 10 months ago (2015-06-11 08:56:49 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 10:12:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196934

Powered by Google App Engine
This is Rietveld 408576698