Change WebContentsDelegate::GetSecurityStyle to take non-const WebContents.

Change WebContentsDelegate::GetSecurityStyle to take non-const WebContents.

Based on the discussion in https://codereview.chromium.org/1162663004 .

BUG=484395
Committed: https://crrev.com/2b0748adaaf7e695a2bb5997d085b1b9e68437aa
Cr-Commit-Position: refs/heads/master@{#334023}

[lgarron, 2015-06-10 22:46:45]

lgarron@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2015-06-10 23:03:48]

Please use 484395 as the bug number.  LGTM.

[Peter Kasting, 2015-06-11 00:19:10]

Wait, what?  I don't read the content guidelines as mandating this.  This seems
like an unreasonable request.

Charlie, if you and John think this is what the guidelines mean, then (a) you
need to rewrite the guidelines to say this, and (b) I think you should create a
chromium-dev thread to discuss it.  I was already unhappy when my comments on
the last CL were not ultimately addressed, but this goes even further than what
I thought we were discussing there.

[Peter Kasting, 2015-06-11 03:44:13]

On 2015/06/11 00:19:10, Peter Kasting wrote:
> Wait, what?  I don't read the content guidelines as mandating this.  This
seems
> like an unreasonable request.
> 
> Charlie, if you and John think this is what the guidelines mean, then (a) you
> need to rewrite the guidelines to say this, and (b) I think you should create
a
> chromium-dev thread to discuss it.  I was already unhappy when my comments on
> the last CL were not ultimately addressed, but this goes even further than
what
> I thought we were discussing there.

I withdraw this request.  I think I was being excessively grouchy earlier.

I do think the content guidelines are unclear about banning the word "const"
entirely.  It looks as if they just disallow const functions.  So do consider
rewriting them.  We had thought we'd complied with your request when the
previous change landed, so it was a surprise to get a sort of "hey, why did you
do what we didn't want" message.  Maybe that was part of my response.

As to having a separate thread, I think there's merit in changing your policy,
and I did my best to say why on the other CL, but ultimately it's up to you guys
to decide whether you agree and what you wish to do about it.

[jam, 2015-06-11 15:56:24]

jam@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2015-06-11 15:56:25]

lgtm

Peter, no worries I don't think you were being grouchy. It's clear we don't see
eye-to-eye on this specific issue. I see your side of the discussion and I agree
with it for code in one module (i.e. within content, or within chrome). We just
differ on whether to apply this across modules to. My experience with the
content api's usage was what led me to add this rule. Given that content now has
many more embedders than before, and to a lesser extent, consistency, I don't
see a strong reason to change the guidelines at this point.

https://codereview.chromium.org/1173213002/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/1173213002/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:1305: WebContents* web_contents) {
nit: this fits on one line

https://codereview.chromium.org/1173213002/diff/1/content/public/browser/web_...
File content/public/browser/web_contents_delegate.cc (right):

https://codereview.chromium.org/1173213002/diff/1/content/public/browser/web_...
content/public/browser/web_contents_delegate.cc:230: WebContents* web_contents)
{
ditto

[lgarron, 2015-06-11 17:56:44]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2015-06-11 17:56:45]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1173213002/#ps20001
(title: "git cl format")

[commit-bot: I haz the power, 2015-06-11 17:57:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1173213002/20001

[commit-bot: I haz the power, 2015-06-11 20:06:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-11 20:07:20]

Patchset 2 (id:??) landed as
https://crrev.com/2b0748adaaf7e695a2bb5997d085b1b9e68437aa
Cr-Commit-Position: refs/heads/master@{#334023}