Work around for nexus 6 TexSubImage issue

Work around for nexus 6 TexSubImage issue

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/c69fe20ef35df0776b179cbd5ce4d1bdc0ba4090

Committed: https://skia.googlesource.com/skia/+/83bc22970364f1ff94751b99c4b4048b3c66e1a2

[joshualitt, 2015-06-17 16:12:08]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[joshualitt, 2015-06-17 16:12:09]

ptal

[bsalomon, 2015-06-17 20:13:31]

Can we add something to GrContextOptions?

Also can we make the language less GL-ish if it has to appear in GrCaps and not
just GrGLCaps? e.g. drawInsteadOfPartialTextureWrite?

[joshualitt, 2015-06-18 15:34:00]

feedback inc

[bsalomon, 2015-06-18 16:53:53]

https://codereview.chromium.org/1173203005/diff/40001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/1173203005/diff/40001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:328: !fCaps->useDrawInsteadOfPartialTextureWrite()) {
check that it is partial (note that the rect is known to be clipped to the
surface so you can just check w < s->w() || h < s->h())

[joshualitt, 2015-06-18 17:52:52]

On 2015/06/18 16:53:53, bsalomon wrote:
> https://codereview.chromium.org/1173203005/diff/40001/src/gpu/GrContext.cpp
> File src/gpu/GrContext.cpp (right):
> 
>
https://codereview.chromium.org/1173203005/diff/40001/src/gpu/GrContext.cpp#n...
> src/gpu/GrContext.cpp:328: !fCaps->useDrawInsteadOfPartialTextureWrite()) {
> check that it is partial (note that the rect is known to be clipped to the
> surface so you can just check w < s->w() || h < s->h())

feedback inc

[bsalomon, 2015-06-18 18:01:29]

lgtm

[joshualitt, 2015-06-18 18:01:44]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-06-18 18:02:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1173203005/60001

[commit-bot: I haz the power, 2015-06-18 18:07:14]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c69fe20ef35df0776b179cbd5ce4d1bdc0ba4090

[f(malita), 2015-06-18 18:44:01]

On 2015/06/18 at 18:07:14, commit-bot wrote:
> Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c69fe20ef35df0776b179cbd5ce4d1bdc0ba4090

Looks like this broke a bunch a N6 GMs, PTAL: https://gold.skia.org/

[joshualitt, 2015-06-18 18:48:49]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1190463006/ by joshualitt@google.com.

The reason for reverting is: breaks gms.

[joshualitt, 2015-06-18 21:09:47]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-06-18 21:09:47]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1173203005/#ps80001
(title: "cleanup")

[commit-bot: I haz the power, 2015-06-18 21:10:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1173203005/80001

[commit-bot: I haz the power, 2015-06-18 21:18:06]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/83bc22970364f1ff94751b99c4b4048b3c66e1a2