Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1173173007: remove dead guarded code for legacy SkData proc (Closed)

Created:
5 years, 6 months ago by reed1
Modified:
5 years, 6 months ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove dead guarded code for legacy SkData proc BUG=skia: Committed: https://skia.googlesource.com/skia/+/7ab04d949bae5e3ad1a5788b0497fc6ea1d86440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -50 lines) Patch
M include/core/SkData.h View 2 chunks +1 line, -16 lines 0 comments Download
M src/core/SkData.cpp View 3 chunks +0 lines, -22 lines 0 comments Download
M tests/DataRefTest.cpp View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
ptal
5 years, 6 months ago (2015-06-18 20:31:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173173007/1
5 years, 6 months ago (2015-06-18 20:31:29 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 6 months ago (2015-06-18 20:31:30 UTC) #5
scroggo
On 2015/06/18 20:31:30, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
5 years, 6 months ago (2015-06-18 20:36:10 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 20:42:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7ab04d949bae5e3ad1a5788b0497fc6ea1d86440

Powered by Google App Engine
This is Rietveld 408576698