Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1173173002: Ink should propagate at a constant velocity (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Ink should propagate at a constant velocity Previously it was propagating for a constant duration. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/4d230db75dde628aaeb78488fc68f7a434a80f8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M sky/sdk/lib/framework/components2/ink_well.dart View 2 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hixie
lgtm I don't really grok what this code actually does. But it looks fine.
5 years, 6 months ago (2015-06-10 21:11:40 UTC) #1
abarth-chromium
5 years, 6 months ago (2015-06-10 21:16:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d230db75dde628aaeb78488fc68f7a434a80f8e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698