Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 117313002: Simplify DocumentOrderedMap (Closed)

Created:
7 years ago by Inactive
Modified:
7 years ago
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Simplify DocumentOrderedMap This CL simplifies DocumentOrderedMap's internal state. Rather than keeping a map separately from the duplicate count, we now keep the duplicate count in the same map. This CL is a fixed version of r155823, which was reverted because it was causing an assertion in clusterfuzz. R=abarth, adamk BUG=265009, 271131 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164029

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -50 lines) Patch
M Source/core/dom/DocumentOrderedMap.h View 1 chunk +19 lines, -7 lines 0 comments Download
M Source/core/dom/DocumentOrderedMap.cpp View 4 chunks +36 lines, -43 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Inactive
7 years ago (2013-12-17 15:33:16 UTC) #1
Inactive
https://codereview.chromium.org/117313002/diff/1/Source/core/dom/DocumentOrderedMap.cpp File Source/core/dom/DocumentOrderedMap.cpp (right): https://codereview.chromium.org/117313002/diff/1/Source/core/dom/DocumentOrderedMap.cpp#newcode91 Source/core/dom/DocumentOrderedMap.cpp:91: if (it == m_map.end()) This is the fix for ...
7 years ago (2013-12-17 15:34:50 UTC) #2
esprehn
lgtm (This just looks like a subset of the patch you posted that I've been ...
7 years ago (2013-12-17 19:05:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/117313002/1
7 years ago (2013-12-17 19:09:04 UTC) #4
Inactive
On 2013/12/17 19:05:37, esprehn wrote: > lgtm (This just looks like a subset of the ...
7 years ago (2013-12-17 19:10:13 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-17 19:15:40 UTC) #6
Message was sent while issue was closed.
Change committed as 164029

Powered by Google App Engine
This is Rietveld 408576698