Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 1173083002: Add DCHECKs for the touch selection menu runner singleton (Closed)

Created:
5 years, 6 months ago by mohsen
Modified:
3 years, 7 months ago
Reviewers:
sadrul, Somcran80
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DCHECKs for the touch selection menu runner singleton This is to ensure that there exists at most one instance of the menu runner simultaneously. This fix is now possible because of the ViewsDelegate refactoring. BUG=399721, 492991 Committed: https://crrev.com/20a7d9f7cf570609d5314fbc6ab3b1514b9e3308 Cr-Commit-Position: refs/heads/master@{#333747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M ui/touch_selection/touch_selection_menu_runner.cc View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mohsen
Please take a look...
5 years, 6 months ago (2015-06-10 15:58:46 UTC) #2
sadrul
lgtm
5 years, 6 months ago (2015-06-10 16:12:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173083002/1
5 years, 6 months ago (2015-06-10 16:13:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 16:58:51 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/20a7d9f7cf570609d5314fbc6ab3b1514b9e3308 Cr-Commit-Position: refs/heads/master@{#333747}
5 years, 6 months ago (2015-06-10 16:59:37 UTC) #7
Somcran80
3 years, 7 months ago (2017-05-16 22:54:01 UTC) #9
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698