Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1173073002: Revert of Componentization: enable linking core and modules separately. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
haraken, tasak
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Componentization: enable linking core and modules separately. (patchset #2 id:20001 of https://codereview.chromium.org/1172253002/) Reason for revert: See https://code.google.com/p/chromium/issues/detail?id=492283#c38 Original issue's description: > Componentization: enable linking core and modules separately. > > BUG=358074 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196852 TBR=haraken@chromium.org,tasak@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196873

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/build/features.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Componentization: enable linking core and modules separately.
4 years, 10 months ago (2015-06-10 14:44:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173073002/1
4 years, 10 months ago (2015-06-10 14:44:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=196873
4 years, 10 months ago (2015-06-10 14:45:26 UTC) #3
haraken
4 years, 10 months ago (2015-06-10 14:53:43 UTC) #4
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698