Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp

Issue 1173053003: Remove ScrollableArea::notifyScrollPositionChanged and cleanup scroll animators. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase + remove updateScrollbars from FrameView::setScrollPosition Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/Page.cpp ('k') | Source/platform/mac/ScrollAnimatorMac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp
diff --git a/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp b/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp
index 5e87c93f3ca5fa06a7f82f8dcb3e4b9397236621..18589dfea6f4fcc6ab4250ea2140223b9644c309 100644
--- a/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp
+++ b/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp
@@ -635,10 +635,7 @@ void DeprecatedPaintLayerScrollableArea::updateAfterLayout()
if (originalScrollOffset != adjustedScrollOffset()) {
DoublePoint origin(scrollOrigin());
-
- // Call the base version here since calling this class' version will early because the
- // offset itself hasn't changed, the scroll origin has.
- ScrollableArea::setScrollPosition(-origin + adjustedScrollOffset(), ProgrammaticScroll);
+ scrollPositionChanged(-origin + adjustedScrollOffset(), ProgrammaticScroll);
}
bool hasHorizontalOverflow = this->hasHorizontalOverflow();
« no previous file with comments | « Source/core/page/Page.cpp ('k') | Source/platform/mac/ScrollAnimatorMac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698