Source/core/frame/RootFrameViewportTest.cpp - Issue 1173053003: Remove ScrollableArea::notifyScrollPositionChanged and cleanup scroll animators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/RootFrameViewportTest.cpp

Issue 1173053003: Remove ScrollableArea::notifyScrollPositionChanged and cleanup scroll animators. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase + remove updateScrollbars from FrameView::setScrollPosition Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/RootFrameViewportTest.cpp

diff --git a/Source/core/frame/RootFrameViewportTest.cpp b/Source/core/frame/RootFrameViewportTest.cpp

index feed133a63d95fdde22c9aeaf8fd2fd93f495d3d..ca9271ff5ba418a490e51600e3b1490ce04cac7e 100644

--- a/Source/core/frame/RootFrameViewportTest.cpp

+++ b/Source/core/frame/RootFrameViewportTest.cpp

@@ -385,7 +385,7 @@ TEST_F(RootFrameViewportTest, ScrollIntoView)

visualViewport.setScale(1.5f);

visualViewport.setScrollPosition(DoublePoint(0, 10), ProgrammaticScroll);

layoutViewport.setScrollPosition(DoublePoint(50, 50), ProgrammaticScroll);

- rootFrameViewport->notifyScrollPositionChanged(rootFrameViewport->scrollPositionDouble());

+ rootFrameViewport->setScrollPosition(rootFrameViewport->scrollPositionDouble(), ProgrammaticScroll);

rootFrameViewport->scrollIntoView(

LayoutRect(rootFrameViewport->visibleContentRectDouble(ExcludeScrollbars)),

« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »