Remove ScrollableArea::notifyScrollPositionChanged and cleanup scroll animators.

Remove ScrollableArea::notifyScrollPositionChanged and cleanup scroll animators.

Removed external uses of notifyScrollPositionChanged. It was previously meant to
be used when the scroll position of a ScrollableArea changed externally, e.g.
scrolls coming from the compositor. However, since it was public, it was used
all over the place for all sorts of reasons.

This patch removes the method altogether in favor of the externally visible
setScrollPosition method and uses the protected scrollPositionChanged method
directly from the scroll animators and internal users.

Also cleaned up the interfaces ScrollAnimator and ProgrammaticScrollAnimator
have/use to make them more symmetric. This included making all programmatic
scrolls go through the ProgrammaticScrollAnimator and user scrolls through
ScrollAnimator. This allowed us to make the ScrollType implicit in the scroll
animators. Truncation to integer scroll offsets was also moved from the
animators to ScrollableArea since it never made much sense where it was.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197500

[bokan, 2015-06-10 15:08:48]

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-10 15:08:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1173053003/1

[commit-bot: I haz the power, 2015-06-10 17:42:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-10 17:42:22]

Dry run: This issue passed the CQ dry run.

[bokan, 2015-06-10 17:43:02]

bokan@chromium.org changed reviewers:
+ skobes@chromium.org

[bokan, 2015-06-10 17:43:23]

Here's the last bit of the "mega-patch". ptal.

[skobes, 2015-06-10 23:08:25]

https://codereview.chromium.org/1173053003/diff/1/Source/platform/scroll/Scro...
File Source/platform/scroll/ScrollAnimatorNone.cpp (left):

https://codereview.chromium.org/1173053003/diff/1/Source/platform/scroll/Scro...
Source/platform/scroll/ScrollAnimatorNone.cpp:438: stopAnimationTimerIfNeeded();
Why do we not need this line anymore?

https://codereview.chromium.org/1173053003/diff/1/Source/platform/scroll/Scro...
File Source/platform/scroll/ScrollAnimatorNone.cpp (right):

https://codereview.chromium.org/1173053003/diff/1/Source/platform/scroll/Scro...
Source/platform/scroll/ScrollAnimatorNone.cpp:442: // the desirect position to
the current.
"desired"

[bokan, 2015-06-11 00:02:22]

https://codereview.chromium.org/1173053003/diff/1/Source/platform/scroll/Scro...
File Source/platform/scroll/ScrollAnimatorNone.cpp (left):

https://codereview.chromium.org/1173053003/diff/1/Source/platform/scroll/Scro...
Source/platform/scroll/ScrollAnimatorNone.cpp:438: stopAnimationTimerIfNeeded();
On 2015/06/10 23:08:25, skobes wrote:
> Why do we not need this line anymore?

We stop the timer in the cancelAnimations() that was added.

https://codereview.chromium.org/1173053003/diff/1/Source/platform/scroll/Scro...
File Source/platform/scroll/ScrollAnimatorNone.cpp (right):

https://codereview.chromium.org/1173053003/diff/1/Source/platform/scroll/Scro...
Source/platform/scroll/ScrollAnimatorNone.cpp:442: // the desirect position to
the current.
On 2015/06/10 23:08:25, skobes wrote:
> "desired"

Done.

[skobes, 2015-06-11 00:03:46]

lgtm

[bokan, 2015-06-11 00:06:09]

bokan@chromium.org changed reviewers:
+ pdr@chromium.org

[bokan, 2015-06-11 00:06:22]

+pdr@ for OWNER

[bokan, 2015-06-12 20:02:00]

ping

[pdr., 2015-06-17 19:44:54]

On 2015/06/12 at 20:02:00, bokan wrote:
> ping

LGTM

[bokan, 2015-06-17 20:13:00]

The CQ bit was checked by bokan@chromium.org

[bokan, 2015-06-17 20:13:01]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/1173053003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2015-06-17 20:13:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1173053003/40001

[commit-bot: I haz the power, 2015-06-17 21:55:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-17 21:55:20]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59324)

[bokan, 2015-06-19 14:25:31]

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

[bokan, 2015-06-19 14:25:32]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/1173053003/#ps60001
(title: "Rebase + remove updateScrollbars from FrameView::setScrollPosition")

[commit-bot: I haz the power, 2015-06-19 14:25:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1173053003/60001

[commit-bot: I haz the power, 2015-06-19 15:22:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 15:22:59]

Dry run: This issue passed the CQ dry run.

[bokan, 2015-06-19 21:19:27]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2015-06-19 21:19:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1173053003/60001

[commit-bot: I haz the power, 2015-06-19 21:22:54]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197500