Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Issue 1173023004: fixes #217, Object members on extension types (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly
Modified:
5 years, 6 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -41 lines) Patch
M lib/runtime/dart/_interceptors.js View 1 9 chunks +13 lines, -13 lines 0 comments Download
M lib/runtime/dart/_internal.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/convert.js View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/core.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 4 chunks +8 lines, -2 lines 0 comments Download
M test/codegen/expect/misc.js View 1 chunk +3 lines, -3 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 1 chunk +18 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 6 months ago (2015-06-10 20:45:40 UTC) #2
vsm
lgtm
5 years, 6 months ago (2015-06-10 20:50:28 UTC) #3
Jennifer Messerly
5 years, 6 months ago (2015-06-10 20:52:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
41c9b480903a2de0c48dac848748ba523f3a3c0a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698