Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1173013002: Deserializer: flush code objects in large object space. (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 6 months ago
Reviewers:
ulan, jbramley
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Deserializer: flush code objects in large object space. R=ulan@chromium.org,jacob.bramley@arm.com Committed: https://crrev.com/400ca17ebb7e91c02b6492f6fce698ab2ba88c71 Cr-Commit-Position: refs/heads/master@{#28905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -52 lines) Patch
M src/snapshot/serialize.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/snapshot/serialize.cc View 5 chunks +61 lines, -49 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 6 months ago (2015-06-10 10:30:06 UTC) #1
jbramley
This fixes the missing `FlushICache` in test-serialize/SerializeToplevelLargeCodeObject.
5 years, 6 months ago (2015-06-10 10:42:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173013002/1
5 years, 6 months ago (2015-06-10 10:55:40 UTC) #4
ulan
lgtm
5 years, 6 months ago (2015-06-10 10:56:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173013002/1
5 years, 6 months ago (2015-06-10 11:07:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 11:24:33 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 11:24:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/400ca17ebb7e91c02b6492f6fce698ab2ba88c71
Cr-Commit-Position: refs/heads/master@{#28905}

Powered by Google App Engine
This is Rietveld 408576698