Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1172903002: Set -fmsc-version appropriately for clang on VS2015 (Closed)

Created:
5 years, 6 months ago by scottmg
Modified:
5 years, 6 months ago
Reviewers:
hans, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set -fmsc-version appropriately for clang on VS2015 Mostly turns on char16_t and char32_t to not error out immediately. R=thakis@chromium.org BUG=82385, 440500, 498544 Committed: https://crrev.com/ec4a2e23d70045832b3ffc12095cab4a89cd629e Cr-Commit-Position: refs/heads/master@{#333657}

Patch Set 1 #

Patch Set 2 : gn #

Patch Set 3 : elseif #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M build/common.gypi View 2 chunks +14 lines, -2 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 1 chunk +7 lines, -2 lines 1 comment Download

Messages

Total messages: 16 (4 generated)
scottmg
5 years, 6 months ago (2015-06-09 23:54:44 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172903002/1
5 years, 6 months ago (2015-06-09 23:57:33 UTC) #3
Nico
cool, lgtm, thanks! Does gn also have some VS2015 toggle? If so, can you do ...
5 years, 6 months ago (2015-06-10 00:12:53 UTC) #4
scottmg
On 2015/06/10 00:12:53, Nico wrote: > cool, lgtm, thanks! Does gn also have some VS2015 ...
5 years, 6 months ago (2015-06-10 00:22:35 UTC) #5
Nico
lgtm!
5 years, 6 months ago (2015-06-10 00:23:32 UTC) #6
Nico
(Oh, and doing a clang/win/gn/debug build requires a checkout that has synced in the last ...
5 years, 6 months ago (2015-06-10 00:24:01 UTC) #7
scottmg
On 2015/06/10 00:24:01, Nico wrote: > (Oh, and doing a clang/win/gn/debug build requires a checkout ...
5 years, 6 months ago (2015-06-10 00:26:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172903002/40001
5 years, 6 months ago (2015-06-10 00:28:10 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-10 02:23:03 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ec4a2e23d70045832b3ffc12095cab4a89cd629e Cr-Commit-Position: refs/heads/master@{#333657}
5 years, 6 months ago (2015-06-10 02:23:52 UTC) #13
hans
https://codereview.chromium.org/1172903002/diff/40001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/1172903002/diff/40001/build/config/compiler/BUILD.gn#newcode116 build/config/compiler/BUILD.gn:116: if (visual_studio_version == "2013") { This buildbot seems sad ...
5 years, 6 months ago (2015-06-10 18:05:38 UTC) #15
hans
5 years, 6 months ago (2015-06-10 18:37:58 UTC) #16
Message was sent while issue was closed. 
On 2015/06/10 18:05:38, hans wrote:
>
https://codereview.chromium.org/1172903002/diff/40001/build/config/compiler/B...
> File build/config/compiler/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1172903002/diff/40001/build/config/compiler/B...
> build/config/compiler/BUILD.gn:116: if (visual_studio_version == "2013") {
> This buildbot seems sad because of this:
>
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/build...

Fix attempt: https://codereview.chromium.org/1178603002/

Powered by Google App Engine
This is Rietveld 408576698