sdk/lib/_internal/compiler/implementation/patch_parser.dart - Issue 11729004: Refactor location computation in dart2js mirrors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sdk/lib/_internal/compiler/implementation/patch_parser.dart

Issue 11729004: Refactor location computation in dart2js mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Location test added. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart ('K') | « sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart ('k') | tests/compiler/dart2js/mirrors_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 /**	5 /**

6 * This library contains the infrastructure to parse and integrate patch files.	6 * This library contains the infrastructure to parse and integrate patch files.

7 *	7 *

8 * Three types of elements can be patched: [LibraryElement], [ClassElement],	8 * Three types of elements can be patched: [LibraryElement], [ClassElement],

9 * [FunctionElement]. Patches are introduced in patch libraries which are loaded	9 * [FunctionElement]. Patches are introduced in patch libraries which are loaded

10 * together with the corresponding origin library. Which libraries that are	10 * together with the corresponding origin library. Which libraries that are

(...skipping 484 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
495 }	495 }

496 super.addMember(element);	496 super.addMember(element);

497 }	497 }

498 }	498 }

499	499

500 // TODO(ahe): Get rid of this class.	500 // TODO(ahe): Get rid of this class.

501 class PatchMetadataAnnotation extends MetadataAnnotation {	501 class PatchMetadataAnnotation extends MetadataAnnotation {

502 final leg.Constant value = null;	502 final leg.Constant value = null;

503	503

504 PatchMetadataAnnotation() : super(STATE_DONE);	504 PatchMetadataAnnotation() : super(STATE_DONE);

	505

	506 Token get beginToken => null;
	Johnni Winther 2013/01/04 09:57:56 Needed in this CL and not in https://codereview.ch Needed in this CL and not in https://codereview.chromium.org/11726005/
505 }	507 }

OLD	NEW