Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1172893002: Revert of Reland of 'Optimize trivial regexp disjunctions' CL 1176453002 (Closed)

Created:
5 years, 6 months ago by erikcorry
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland of 'Optimize trivial regexp disjunctions' CL 1176453002 (patchset #2 id:20001 of https://codereview.chromium.org/1174713002/) Reason for revert: Tree looks like a Christmas tree and this isn't helping Original issue's description: > Reland of 'Optimize trivial regexp disjunctions' CL 1176453002 > > Original code review: https://codereview.chromium.org/1176453002/ > > TBR=yangguo@chromium.org > BUG=chromium:482998 > LOG=n > > Committed: https://crrev.com/85fab0fa092e8d979413f6a61baec3abe26e568d > Cr-Commit-Position: refs/heads/master@{#28884} TBR=yangguo@chromium.org,erikcorry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:482998 Committed: https://crrev.com/9b8a56d4335ac5e591c6da5fe4354a4c49734031 Cr-Commit-Position: refs/heads/master@{#28885}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -246 lines) Patch
M src/ast.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/jsregexp.h View 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.cc View 1 chunk +0 lines, -190 lines 0 comments Download
M src/list.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/list-inl.h View 2 chunks +4 lines, -31 lines 0 comments Download
M src/vector.h View 2 chunks +0 lines, -14 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
erikcorry
Created Revert of Reland of 'Optimize trivial regexp disjunctions' CL 1176453002
5 years, 6 months ago (2015-06-09 23:06:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172893002/1
5 years, 6 months ago (2015-06-09 23:06:37 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-09 23:06:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172893002/1
5 years, 6 months ago (2015-06-09 23:08:57 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-09 23:08:59 UTC) #8
Erik Corry Chromium.org
lgtm
5 years, 6 months ago (2015-06-09 23:09:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172893002/1
5 years, 6 months ago (2015-06-09 23:09:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 23:10:12 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 23:10:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b8a56d4335ac5e591c6da5fe4354a4c49734031
Cr-Commit-Position: refs/heads/master@{#28885}

Powered by Google App Engine
This is Rietveld 408576698