Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: cc/surfaces/surfaces_pixeltest.cc

Issue 1172883004: Don't aggregate quads outside of damage rect when using partial swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@predamage
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/surfaces/surface_aggregator_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/compositor_frame.h" 5 #include "cc/output/compositor_frame.h"
6 #include "cc/quads/render_pass.h" 6 #include "cc/quads/render_pass.h"
7 #include "cc/quads/solid_color_draw_quad.h" 7 #include "cc/quads/solid_color_draw_quad.h"
8 #include "cc/quads/surface_draw_quad.h" 8 #include "cc/quads/surface_draw_quad.h"
9 #include "cc/surfaces/surface.h" 9 #include "cc/surfaces/surface.h"
10 #include "cc/surfaces/surface_aggregator.h" 10 #include "cc/surfaces/surface_aggregator.h"
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 delegated_frame_data->render_pass_list.push_back(pass.Pass()); 76 delegated_frame_data->render_pass_list.push_back(pass.Pass());
77 77
78 scoped_ptr<CompositorFrame> root_frame(new CompositorFrame); 78 scoped_ptr<CompositorFrame> root_frame(new CompositorFrame);
79 root_frame->delegated_frame_data = delegated_frame_data.Pass(); 79 root_frame->delegated_frame_data = delegated_frame_data.Pass();
80 80
81 SurfaceId root_surface_id = allocator_.GenerateId(); 81 SurfaceId root_surface_id = allocator_.GenerateId();
82 factory_.Create(root_surface_id); 82 factory_.Create(root_surface_id);
83 factory_.SubmitFrame(root_surface_id, root_frame.Pass(), 83 factory_.SubmitFrame(root_surface_id, root_frame.Pass(),
84 SurfaceFactory::DrawCallback()); 84 SurfaceFactory::DrawCallback());
85 85
86 SurfaceAggregator aggregator(&manager_, resource_provider_.get()); 86 SurfaceAggregator aggregator(&manager_, resource_provider_.get(), true);
87 scoped_ptr<CompositorFrame> aggregated_frame = 87 scoped_ptr<CompositorFrame> aggregated_frame =
88 aggregator.Aggregate(root_surface_id); 88 aggregator.Aggregate(root_surface_id);
89 factory_.Destroy(root_surface_id); 89 factory_.Destroy(root_surface_id);
90 90
91 bool discard_alpha = false; 91 bool discard_alpha = false;
92 ExactPixelComparator pixel_comparator(discard_alpha); 92 ExactPixelComparator pixel_comparator(discard_alpha);
93 RenderPassList* pass_list = 93 RenderPassList* pass_list =
94 &aggregated_frame->delegated_frame_data->render_pass_list; 94 &aggregated_frame->delegated_frame_data->render_pass_list;
95 EXPECT_TRUE(RunPixelTest(pass_list, 95 EXPECT_TRUE(RunPixelTest(pass_list,
96 base::FilePath(FILE_PATH_LITERAL("green.png")), 96 base::FilePath(FILE_PATH_LITERAL("green.png")),
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 scoped_ptr<DelegatedFrameData> delegated_frame_data(new DelegatedFrameData); 160 scoped_ptr<DelegatedFrameData> delegated_frame_data(new DelegatedFrameData);
161 delegated_frame_data->render_pass_list.push_back(pass.Pass()); 161 delegated_frame_data->render_pass_list.push_back(pass.Pass());
162 162
163 scoped_ptr<CompositorFrame> child_frame(new CompositorFrame); 163 scoped_ptr<CompositorFrame> child_frame(new CompositorFrame);
164 child_frame->delegated_frame_data = delegated_frame_data.Pass(); 164 child_frame->delegated_frame_data = delegated_frame_data.Pass();
165 165
166 factory_.SubmitFrame(child_surface_id, child_frame.Pass(), 166 factory_.SubmitFrame(child_surface_id, child_frame.Pass(),
167 SurfaceFactory::DrawCallback()); 167 SurfaceFactory::DrawCallback());
168 } 168 }
169 169
170 SurfaceAggregator aggregator(&manager_, resource_provider_.get()); 170 SurfaceAggregator aggregator(&manager_, resource_provider_.get(), true);
171 scoped_ptr<CompositorFrame> aggregated_frame = 171 scoped_ptr<CompositorFrame> aggregated_frame =
172 aggregator.Aggregate(root_surface_id); 172 aggregator.Aggregate(root_surface_id);
173 173
174 bool discard_alpha = false; 174 bool discard_alpha = false;
175 ExactPixelComparator pixel_comparator(discard_alpha); 175 ExactPixelComparator pixel_comparator(discard_alpha);
176 RenderPassList* pass_list = 176 RenderPassList* pass_list =
177 &aggregated_frame->delegated_frame_data->render_pass_list; 177 &aggregated_frame->delegated_frame_data->render_pass_list;
178 EXPECT_TRUE(RunPixelTest(pass_list, 178 EXPECT_TRUE(RunPixelTest(pass_list,
179 base::FilePath(FILE_PATH_LITERAL("blue_yellow.png")), 179 base::FilePath(FILE_PATH_LITERAL("blue_yellow.png")),
180 pixel_comparator)); 180 pixel_comparator));
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 scoped_ptr<DelegatedFrameData> delegated_frame_data(new DelegatedFrameData); 303 scoped_ptr<DelegatedFrameData> delegated_frame_data(new DelegatedFrameData);
304 delegated_frame_data->render_pass_list.push_back(pass.Pass()); 304 delegated_frame_data->render_pass_list.push_back(pass.Pass());
305 305
306 scoped_ptr<CompositorFrame> child_frame(new CompositorFrame); 306 scoped_ptr<CompositorFrame> child_frame(new CompositorFrame);
307 child_frame->delegated_frame_data = delegated_frame_data.Pass(); 307 child_frame->delegated_frame_data = delegated_frame_data.Pass();
308 308
309 factory_.SubmitFrame(right_child_id, child_frame.Pass(), 309 factory_.SubmitFrame(right_child_id, child_frame.Pass(),
310 SurfaceFactory::DrawCallback()); 310 SurfaceFactory::DrawCallback());
311 } 311 }
312 312
313 SurfaceAggregator aggregator(&manager_, resource_provider_.get()); 313 SurfaceAggregator aggregator(&manager_, resource_provider_.get(), true);
314 scoped_ptr<CompositorFrame> aggregated_frame = 314 scoped_ptr<CompositorFrame> aggregated_frame =
315 aggregator.Aggregate(root_surface_id); 315 aggregator.Aggregate(root_surface_id);
316 316
317 bool discard_alpha = false; 317 bool discard_alpha = false;
318 ExactPixelComparator pixel_comparator(discard_alpha); 318 ExactPixelComparator pixel_comparator(discard_alpha);
319 RenderPassList* pass_list = 319 RenderPassList* pass_list =
320 &aggregated_frame->delegated_frame_data->render_pass_list; 320 &aggregated_frame->delegated_frame_data->render_pass_list;
321 EXPECT_TRUE(RunPixelTest( 321 EXPECT_TRUE(RunPixelTest(
322 pass_list, 322 pass_list,
323 base::FilePath(FILE_PATH_LITERAL("four_blue_green_checkers.png")), 323 base::FilePath(FILE_PATH_LITERAL("four_blue_green_checkers.png")),
324 pixel_comparator)); 324 pixel_comparator));
325 325
326 factory_.Destroy(root_surface_id); 326 factory_.Destroy(root_surface_id);
327 factory_.Destroy(left_child_id); 327 factory_.Destroy(left_child_id);
328 factory_.Destroy(right_child_id); 328 factory_.Destroy(right_child_id);
329 } 329 }
330 330
331 } // namespace 331 } // namespace
332 } // namespace cc 332 } // namespace cc
333 333
334 #endif // !defined(OS_ANDROID) 334 #endif // !defined(OS_ANDROID)
OLDNEW
« no previous file with comments | « cc/surfaces/surface_aggregator_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698