Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1172883003: Fix for undesired audio blip when closing a muted tab. (Closed)

Created:
5 years, 6 months ago by miu
Modified:
5 years, 6 months ago
Reviewers:
Dale Curtis, DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for undesired audio blip when closing a muted tab. AudioRendererHost was calling AudioMirroringManager::RemoveDiverter() just before AudioOutputController::Close(). This caused AOC to re-start the default audio output stream (to the user's speakers) for 0-50+ milliseconds before closing and shutting down. This change fixes the problem by moving the RemoveDiverter() call to a point after AOC has completed its close operation, which results in no new streams starting up during this shutdown process. BUG=474432 Committed: https://crrev.com/04eb0d223d2aaa440839ac7d9fe47148fcae83ac Cr-Commit-Position: refs/heads/master@{#333684}

Patch Set 1 #

Patch Set 2 : Fix crash on Windows (grab pointer before scoped_ptr is passed). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
miu
dalecurtis: PTAL.
5 years, 6 months ago (2015-06-10 00:34:44 UTC) #2
DaleCurtis
lgtm
5 years, 6 months ago (2015-06-10 00:38:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172883003/20001
5 years, 6 months ago (2015-06-10 03:29:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-10 04:30:03 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 04:31:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04eb0d223d2aaa440839ac7d9fe47148fcae83ac
Cr-Commit-Position: refs/heads/master@{#333684}

Powered by Google App Engine
This is Rietveld 408576698