Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1172873002: cc: Init PaintedScrollbarLayer::internal_contents_scale_ to 1. (Closed)

Created:
5 years, 6 months ago by danakj
Modified:
5 years, 6 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Init PaintedScrollbarLayer::internal_contents_scale_ to 1. This scale is currently 0, but if a PaintedScrollbarLayerImpl ends up in the RenderSurfaceLayerList, we'll try to get the layer's rect in target space. Since the scale is 0 we end up dividing by 0 and get a NaN which is bad times. If we init this to 1 things work until the PaintedScrollbarLayer has a chance to Update(). R=enne BUG=497947 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/69a27e219afcbb540b10e012f7e3bcad00b38e6a Cr-Commit-Position: refs/heads/master@{#333653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/layers/painted_scrollbar_layer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
danakj
5 years, 6 months ago (2015-06-09 22:28:32 UTC) #1
enne (OOO)
lgtm
5 years, 6 months ago (2015-06-09 22:31:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172873002/1
5 years, 6 months ago (2015-06-09 22:41:30 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/75039)
5 years, 6 months ago (2015-06-09 23:54:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172873002/1
5 years, 6 months ago (2015-06-09 23:57:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 02:11:18 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 02:12:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69a27e219afcbb540b10e012f7e3bcad00b38e6a
Cr-Commit-Position: refs/heads/master@{#333653}

Powered by Google App Engine
This is Rietveld 408576698