Telemetry: Add 'wait_after' parameter to gesture actions.

Telemetry: Add 'wait_after' parameter to gesture actions.

Gesture actions can kick off animations on some pages. We want to be able to
measure the interval from the beginning of the gesture to the end of the
animation (without gaps). The 'wait_after' parameter allows the user to specify
a condition on which to wait after performing a gesture. The resulting active
range of the page action covers both the gesture and the condition.

BUG=323275
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243663

[Dominik Grewe, 2013-12-17 18:01:23]

PTAL, thanks!

[Sami, 2013-12-18 14:01:59]

lgtm.

https://codereview.chromium.org/117283004/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/timeline/bounds.py (right):

https://codereview.chromium.org/117283004/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/timeline/bounds.py:51: if bounds.is_empty:
whoops :)

[nduca, 2014-01-07 18:04:02]

lgtm

[Dominik Grewe, 2014-01-08 10:40:11]

I've added a unit test. Sami, Nat, can one of you have a look before I submit?

[Sami, 2014-01-08 11:11:14]

Thanks for the test! Few notes below.

https://codereview.chromium.org/117283004/diff/30001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/page/actions/gesture_action_unittest.py (right):

https://codereview.chromium.org/117283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/actions/gesture_action_unittest.py:1: # Copyright
(c) 2012 The Chromium Authors. All rights reserved.
year += 2 :)

https://codereview.chromium.org/117283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/actions/gesture_action_unittest.py:18: duration =
2
Nit: slightly more pythonic: duration = getattr(self, 'duration', 2)

https://codereview.chromium.org/117283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/actions/gesture_action_unittest.py:27:
self._browser.SetHTTPServerDirectories(util.GetUnittestDataDir())
Would it be enough just to navigate to about:blank or do we need an actual
server and page?

https://codereview.chromium.org/117283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/actions/gesture_action_unittest.py:43:
self.assertTrue(time.time() - start_time >= 1.0)
Nit: assertGreaterEqual

https://codereview.chromium.org/117283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/actions/gesture_action_unittest.py:53:
self.assertTrue(time.time() - start_time >= 2.0)
Nit: assertGreaterEqual

[Dominik Grewe, 2014-01-08 11:45:16]

Thanks Sami. Updated.

https://codereview.chromium.org/117283004/diff/30001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/page/actions/gesture_action_unittest.py (right):

https://codereview.chromium.org/117283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/actions/gesture_action_unittest.py:27:
self._browser.SetHTTPServerDirectories(util.GetUnittestDataDir())
On 2014/01/08 11:11:14, Sami wrote:
> Would it be enough just to navigate to about:blank or do we need an actual
> server and page?

I think you're right. We open a tab with about:blank by default, so we don't
need this function.

[Sami, 2014-01-08 11:58:21]

lgtm, thanks!

[commit-bot: I haz the power, 2014-01-08 12:13:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominikg@chromium.org/117283004/120001

[commit-bot: I haz the power, 2014-01-08 16:19:11]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 16:24:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominikg@chromium.org/117283004/120001

[commit-bot: I haz the power, 2014-01-08 21:10:35]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2014-01-08 21:58:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominikg@chromium.org/117283004/120001

[commit-bot: I haz the power, 2014-01-08 22:03:55]

Change committed as 243663