chrome/browser/ui/android/javascript_app_modal_dialog_android.h - Issue 11728004: Fix use after free in JavascriptAppModalDialogAndroid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/javascript_app_modal_dialog_android.h

Issue 11728004: Fix use after free in JavascriptAppModalDialogAndroid. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add missing 'virtual' (only needed by the Chromium style Clang plugin) Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/android/javascript_app_modal_dialog_android.h

diff --git a/chrome/browser/ui/android/javascript_app_modal_dialog_android.h b/chrome/browser/ui/android/javascript_app_modal_dialog_android.h

index 8d9b09e12b4a33f39b8b251b26fde4b456a43acb..75ce74f193ad7bcfd1d09980cc0e0090ba6961e2 100644

--- a/chrome/browser/ui/android/javascript_app_modal_dialog_android.h

+++ b/chrome/browser/ui/android/javascript_app_modal_dialog_android.h

@@ -17,7 +17,6 @@ class JavascriptAppModalDialogAndroid : public NativeAppModalDialog {

JavascriptAppModalDialogAndroid(JNIEnv* env,

JavaScriptAppModalDialog* dialog,

gfx::NativeWindow parent);

- virtual ~JavascriptAppModalDialogAndroid();

// NativeAppModalDialog:

virtual int GetAppModalDialogButtons() const OVERRIDE;

@@ -39,6 +38,9 @@ class JavascriptAppModalDialogAndroid : public NativeAppModalDialog {

static bool RegisterJavascriptAppModalDialog(JNIEnv* env);

private:

+ // The object deletes itself.

+ virtual ~JavascriptAppModalDialogAndroid();

scoped_ptr<JavaScriptAppModalDialog> dialog_;

base::android::ScopedJavaGlobalRef<jobject> dialog_jobject_;

JavaObjectWeakGlobalRef parent_jobject_weak_ref_;