Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(181)

Issue 1172793005: Fon't drop the FontSelector in LayoutThemeMac::setFontFromControlSize. (Closed)

Created:
4 years, 10 months ago by esprehn
Modified:
4 years, 10 months ago
Reviewers:
kenjibaheux, dglazkov, ojan
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fon't drop the FontSelector in LayoutThemeMac::setFontFromControlSize. Dropping the selector meant that the check in LayoutMenuList::styleDidChange that compares the fonts of the old and new style will always be false so we'll end up doing the updateOptionsWidth() logic for every style change on OS X. R=dglazkov@chromium.org BUG=498522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/core/layout/LayoutThemeMac.mm View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172793005/1
4 years, 10 months ago (2015-06-09 22:20:43 UTC) #2
esprehn
Who does fonts??
4 years, 10 months ago (2015-06-09 23:45:16 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-10 01:18:54 UTC) #6
dglazkov
lgtm
4 years, 10 months ago (2015-06-10 01:27:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172793005/1
4 years, 10 months ago (2015-06-10 01:28:17 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 01:31:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196811

Powered by Google App Engine
This is Rietveld 408576698