Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: src/compiler/node-properties.h

Issue 1172773003: [turbofan] Deprecate NodeProperties::ReplaceWithValue. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/compiler/node-properties.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/node-properties.h
diff --git a/src/compiler/node-properties.h b/src/compiler/node-properties.h
index 0f25051e4e06c073156d9d6863b40943dffea34e..6d11f6cfcce507ce8b1b47a8066d2ceacab23d05 100644
--- a/src/compiler/node-properties.h
+++ b/src/compiler/node-properties.h
@@ -88,11 +88,11 @@ class NodeProperties final {
static void MergeControlToEnd(Graph* graph, CommonOperatorBuilder* common,
Node* node);
- // Replace value uses of {node} with {value} and effect uses of {node} with
- // {effect}. If {effect == NULL}, then use the effect input to {node}. All
- // control uses will be relaxed assuming {node} cannot throw.
- static void ReplaceWithValue(Node* node, Node* value, Node* effect = nullptr,
- Node* control = nullptr);
+ // Replace all uses of {node} with the given replacement nodes. All occurring
+ // use kinds need to be replaced, {NULL} is only valid if a use kind is
+ // guaranteed not to exist.
+ static void ReplaceUses(Node* node, Node* value, Node* effect = nullptr,
+ Node* success = nullptr, Node* exception = nullptr);
// ---------------------------------------------------------------------------
// Miscellaneous utilities.
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/compiler/node-properties.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698