Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1172773003: [turbofan] Deprecate NodeProperties::ReplaceWithValue. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Deprecate NodeProperties::ReplaceWithValue. This deprecates the aforementioned mutator in favor of a simpler NodeProperties::ReplaceUses that doesn't perform any relaxation. Preparation for enabling support for try-catch statements. R=bmeurer@chromium.org TEST=unittests/NodePropertiesTest Committed: https://crrev.com/23d7123cfffe23587d11c430f9f65b255a629880 Cr-Commit-Position: refs/heads/master@{#28897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -87 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/change-lowering.cc View 2 chunks +21 lines, -11 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 5 chunks +22 lines, -8 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/compiler/node-properties.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/compiler/node-properties.cc View 1 chunk +12 lines, -13 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-properties-unittest.cc View 1 chunk +31 lines, -47 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-10 08:32:46 UTC) #1
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-10 09:09:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172773003/1
5 years, 6 months ago (2015-06-10 09:09:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 09:13:59 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 09:14:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23d7123cfffe23587d11c430f9f65b255a629880
Cr-Commit-Position: refs/heads/master@{#28897}

Powered by Google App Engine
This is Rietveld 408576698