Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(150)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1172733002: Devtools: Fix ctrl-z in ColorPicker (Closed)

Created:
4 years, 10 months ago by sergeyv
Modified:
4 years, 10 months ago
Reviewers:
lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: Fix ctrl-z in ColorPicker BUG=497713 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197096

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rework #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -26 lines) Patch
M Source/devtools/front_end/elements/Spectrum.js View 1 7 chunks +9 lines, -22 lines 0 comments Download
M Source/devtools/front_end/elements/spectrum.css View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/UIUtils.js View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
sergeyv
4 years, 10 months ago (2015-06-09 17:36:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172733002/1
4 years, 10 months ago (2015-06-09 17:36:48 UTC) #4
pfeldman
https://codereview.chromium.org/1172733002/diff/1/Source/devtools/front_end/elements/Spectrum.js File Source/devtools/front_end/elements/Spectrum.js (right): https://codereview.chromium.org/1172733002/diff/1/Source/devtools/front_end/elements/Spectrum.js#newcode308 Source/devtools/front_end/elements/Spectrum.js:308: if (isEscKey(event) || isEnterKey(event)) For consistency, we could call ...
4 years, 10 months ago (2015-06-09 18:24:08 UTC) #5
pfeldman
Oh, wait WebInspector.isEditing is already smart enough and should just work!
4 years, 10 months ago (2015-06-09 18:25:11 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-09 20:09:52 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172733002/20001
4 years, 10 months ago (2015-06-11 08:12:06 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-11 09:33:55 UTC) #12
sergeyv
Please take a look
4 years, 10 months ago (2015-06-12 12:30:34 UTC) #13
pfeldman
lgtm
4 years, 10 months ago (2015-06-12 20:07:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172733002/20001
4 years, 10 months ago (2015-06-14 11:06:13 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2015-06-14 11:53:32 UTC) #17
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197096

Powered by Google App Engine
This is Rietveld 408576698