Add min and max to Iterable and Stream.

Add min and max to Iterable and Stream.

R=ajohnsen@google.com

Committed: https://code.google.com/p/dart/source/detail?r=16572

[Anders Johnsen, 2013-01-02 11:04:05]

LGTM

https://codereview.chromium.org/11727007/diff/1/runtime/lib/byte_array.dart
File runtime/lib/byte_array.dart (right):

https://codereview.chromium.org/11727007/diff/1/runtime/lib/byte_array.dart#n...
runtime/lib/byte_array.dart:326: int min([int compare(int a, int b)]) =>
Collections.min(this, compare);
As far as I remember, Float32List extends this object?

https://codereview.chromium.org/11727007/diff/1/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/11727007/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:275: * If the stream is emtpy, the result is [:null:].
empty

https://codereview.chromium.org/11727007/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:276: * Otherwise the result is an value from the
stream that is not greater
a value

https://codereview.chromium.org/11727007/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:294: onDone: () {
Is it an error if there ain't any elements?

https://codereview.chromium.org/11727007/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:302: * Finds the least element in the stream.
Update comment, largest element.

https://codereview.chromium.org/11727007/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:304: * If the stream is emtpy, the result is [:null:].
Ditto

https://codereview.chromium.org/11727007/diff/1/sdk/lib/collection/collection...
File sdk/lib/collection/collections.dart (right):

https://codereview.chromium.org/11727007/diff/1/sdk/lib/collection/collection...
sdk/lib/collection/collections.dart:77: return null;
State error? [].min() -> null?

https://codereview.chromium.org/11727007/diff/1/sdk/lib/svg/dart2js/svg_dart2...
File sdk/lib/svg/dart2js/svg_dart2js.dart (right):

https://codereview.chromium.org/11727007/diff/1/sdk/lib/svg/dart2js/svg_dart2...
sdk/lib/svg/dart2js/svg_dart2js.dart:2906: Length min([int compare(Length a,
Length b)]) => _Collections.minInList(this, compare);
Where is minInList defined?

[Lasse Reichstein Nielsen, 2013-01-02 11:49:33]

https://codereview.chromium.org/11727007/diff/1/runtime/lib/byte_array.dart
File runtime/lib/byte_array.dart (right):

https://codereview.chromium.org/11727007/diff/1/runtime/lib/byte_array.dart#n...
runtime/lib/byte_array.dart:326: int min([int compare(int a, int b)]) =>
Collections.min(this, compare);
You are right. The getters above, and several other methods, are also wrong.
I'll change them to num.

https://codereview.chromium.org/11727007/diff/1/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/11727007/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:275: * If the stream is emtpy, the result is [:null:].
On 2013/01/02 11:04:05, Anders Johnsen wrote:
> empty

Done.

https://codereview.chromium.org/11727007/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:276: * Otherwise the result is an value from the
stream that is not greater
On 2013/01/02 11:04:05, Anders Johnsen wrote:
> a value

Done.

https://codereview.chromium.org/11727007/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:294: onDone: () {
No, min returns null in that case, also in Iterable.

https://codereview.chromium.org/11727007/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:302: * Finds the least element in the stream.
On 2013/01/02 11:04:05, Anders Johnsen wrote:
> Update comment, largest element.

Done.

https://codereview.chromium.org/11727007/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:304: * If the stream is emtpy, the result is [:null:].
On 2013/01/02 11:04:05, Anders Johnsen wrote:
> Ditto

Done.

https://codereview.chromium.org/11727007/diff/1/sdk/lib/collection/collection...
File sdk/lib/collection/collections.dart (right):

https://codereview.chromium.org/11727007/diff/1/sdk/lib/collection/collection...
sdk/lib/collection/collections.dart:77: return null;
It's deliberate. We can argue whether it's the right thing to do :).
What I *really* would want is the interface:
  min([int compare(a,b)], {var ifEmpty})
but until we get both optional positional and named arguments, I'll just default
to null.

https://codereview.chromium.org/11727007/diff/1/sdk/lib/svg/dart2js/svg_dart2...
File sdk/lib/svg/dart2js/svg_dart2js.dart (right):

https://codereview.chromium.org/11727007/diff/1/sdk/lib/svg/dart2js/svg_dart2...
sdk/lib/svg/dart2js/svg_dart2js.dart:2906: Length min([int compare(Length a,
Length b)]) => _Collections.minInList(this, compare);
in _Collections! :P
It's a helper class in _Collections.dart and it already has other List-specific
helpers.

[Sean Eagan, 2013-01-02 16:35:13]

Glad to see this!  Noticed a couple bugs.

https://codereview.chromium.org/11727007/diff/6001/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/11727007/diff/6001/sdk/lib/async/stream.dart#...
sdk/lib/async/stream.dart:305: * Otherwise the result is an value from the
stream that is not greater
greater -> less ?

https://codereview.chromium.org/11727007/diff/6001/sdk/lib/core/iterable.dart
File sdk/lib/core/iterable.dart (right):

https://codereview.chromium.org/11727007/diff/6001/sdk/lib/core/iterable.dart...
sdk/lib/core/iterable.dart:166: while (it.moveNext) {
it.moveNext()

https://codereview.chromium.org/11727007/diff/6001/sdk/lib/core/iterable.dart...
sdk/lib/core/iterable.dart:189: while (it.moveNext) {
it.moveNext()