remove subclassing from ImageFilter::Proxy

src/core/SkImageFilter.cpp

 /*
  * Copyright 2012 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkImageFilter.h"
 
 #include "SkBitmap.h"
@@ skipping 505 matching lines @@
 
 SK_DECLARE_STATIC_LAZY_PTR(SkImageFilter::Cache, cache, CreateCache);
 
 SkImageFilter::Cache* SkImageFilter::Cache::Get() {
     return cache.get();
 }
 
 void SkImageFilter::PurgeCache() {
     cache.get()->purge();
 }
+
+///////////////////////////////////////////////////////////////////////////////////////////////////
+
+#include "SkBitmapDevice.h"

[Stephen White, 2015/06/09 15:17:04]

Nit: move this to top-of-file?

+
+SkBaseDevice* SkImageFilter::Proxy::createDevice(int w, int h) {
+    SkBaseDevice::CreateInfo cinfo(SkImageInfo::MakeN32Premul(w, h),

[robertphillips, 2015/06/09 17:07:29]

What about the SkTileImageFilter?

[Stephen White, 2015/06/10 14:42:45]

SkTileImageFilter always does an extractSubset() of its input, which I believe
makes it tiling-safe, even on GPU.

At any rate, this code is not new -- Mike just moved it here from
SkDeviceImageFilterProxy.

+                                   SkBaseDevice::kNever_TileUsage,
+                                   kUnknown_SkPixelGeometry,
+                                   true /*forImageFilter*/);
+    SkBaseDevice* dev = fDevice->onCreateDevice(cinfo, NULL);

[robertphillips, 2015/06/09 17:07:29]

!dev ?

+    if (NULL == dev) {
+        dev = SkBitmapDevice::Create(cinfo.fInfo);
+    }
+    return dev;
+}
+
+bool SkImageFilter::Proxy::filterImage(const SkImageFilter* filter, const SkBitmap& src,
+                                       const SkImageFilter::Context& ctx,
+                                       SkBitmap* result, SkIPoint* offset) {
+    return fDevice->filterImage(filter, src, ctx, result, offset);
+}
+