src/runtime/runtime-array.cc - Issue 1172683003: Use the LookupIterator for SetElement and friends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-array.cc

Issue 1172683003: Use the LookupIterator for SetElement and friends (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-array.cc

diff --git a/src/runtime/runtime-array.cc b/src/runtime/runtime-array.cc

index 3f05540ef80d6d0b47d1139cec9674c24cfcef11..c468673dd5298f472a91d1a89edbdbf7ba4d2877 100644

--- a/src/runtime/runtime-array.cc

+++ b/src/runtime/runtime-array.cc

@@ -101,7 +101,7 @@ RUNTIME_FUNCTION(Runtime_PushIfAbsent) {

// Strict not needed. Used for cycle detection in Array join implementation.

RETURN_FAILURE_ON_EXCEPTION(

- isolate, JSObject::SetFastElement(array, length, element, SLOPPY, true));

+ isolate, JSObject::AddDataElement(array, length, element, NONE));

return isolate->heap()->true_value();

}

« no previous file with comments | « src/runtime/runtime.h ('k') | src/runtime/runtime-classes.cc » ('j') | no next file with comments »