Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: src/lookup.h

Issue 1172683003: Use the LookupIterator for SetElement and friends (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/liveedit.cc ('k') | src/lookup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.h
diff --git a/src/lookup.h b/src/lookup.h
index 29b7d77b270d26447f8190d651ba1c1704462834..be8394afec4e7242fd294695f6b31f347dac8628 100644
--- a/src/lookup.h
+++ b/src/lookup.h
@@ -212,9 +212,9 @@ class LookupIterator final BASE_EMBEDDED {
Handle<Object> GetAccessors() const;
Handle<InterceptorInfo> GetInterceptor() const;
Handle<Object> GetDataValue() const;
- // Usually returns the value that was passed in, but may perform
- // non-observable modifications on it, such as internalize strings.
- void WriteDataValue(Handle<Object> value);
+ // Usually returns the value that was passed in. In case of typed array
+ // accesses it returns the converted value.
+ Handle<Object> WriteDataValue(Handle<Object> value);
void InternalizeName();
private:
« no previous file with comments | « src/liveedit.cc ('k') | src/lookup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698