Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: test/cctest/test-api.cc

Issue 1172683003: Use the LookupIterator for SetElement and friends (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Update reconfigure data property for sloppy arguments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 849833e58018e9714ff82228bacfdaf138461993..c0e83948d9d4fc7d839ccaf363986e7067b0238c 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -13266,12 +13266,10 @@ TEST(ForceSet) {
CHECK_EQ(3, global->Get(access_property)->Int32Value());
CHECK_EQ(1, force_set_set_count);
CHECK_EQ(2, force_set_get_count);
- // Forcing the property to be set should override the accessor without
- // calling it
global->ForceSet(access_property, v8::Int32::New(isolate, 8));
Igor Sheludko 2015/06/11 13:44:25 I think it makes sense to add the above comment he
Toon Verwaest 2015/06/11 14:26:50 Done.
- CHECK_EQ(8, global->Get(access_property)->Int32Value());
- CHECK_EQ(1, force_set_set_count);
- CHECK_EQ(2, force_set_get_count);
+ CHECK_EQ(3, global->Get(access_property)->Int32Value());
+ CHECK_EQ(2, force_set_set_count);
+ CHECK_EQ(3, force_set_get_count);
}
« src/objects.cc ('K') | « src/runtime/runtime-object.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698