src/json-parser.h - Issue 1172683003: Use the LookupIterator for SetElement and friends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/json-parser.h

Issue 1172683003: Use the LookupIterator for SetElement and friends (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Update reconfigure data property for sloppy arguments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/json-parser.h

diff --git a/src/json-parser.h b/src/json-parser.h

index cecac9bfdb128bb1a8ba374aae7f95633e281c71..9234e85aa20d171fcad6a1f27a5317457debee1b 100644

--- a/src/json-parser.h

+++ b/src/json-parser.h

@@ -325,7 +325,8 @@ ParseElementResult JsonParser<seq_one_byte>::ParseElement(

AdvanceSkipWhitespace();

Handle<Object> value = ParseJsonValue();

if (!value.is_null()) {

- JSObject::SetOwnElement(json_object, index, value, SLOPPY).Assert();

+ JSObject::SetOwnElementIgnoreAttributes(json_object, index, value, NONE)

+ .Assert();

return kElementFound;

} else {

return kNullHandle;