Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: src/elements.h

Issue 1172683003: Use the LookupIterator for SetElement and friends (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Update reconfigure data property for sloppy arguments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast.cc ('k') | src/elements.cc » ('j') | src/objects.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.h
diff --git a/src/elements.h b/src/elements.h
index 49faeab0dbd04012b87de6d22067e5cb72040b10..7dbd7ef4dbf5501f3da9e89431f51db45586740c 100644
--- a/src/elements.h
+++ b/src/elements.h
@@ -43,6 +43,10 @@ class ElementsAccessor {
return HasElement(holder, key, handle(holder->elements()));
}
+ inline Handle<Object> Set(Handle<JSObject> holder, uint32_t key,
+ Handle<Object> value) {
+ return Set(holder, key, handle(holder->elements()), value);
+ }
Igor Sheludko 2015/06/11 14:38:18 Empty line is missing.
// Returns the element with the specified key or undefined if there is no such
// element. This method doesn't iterate up the prototype chain. The caller
// can optionally pass in the backing store to use for the check, which must
@@ -188,6 +192,10 @@ class ElementsAccessor {
virtual bool HasIndex(FixedArrayBase* backing_store, uint32_t key) = 0;
private:
+ virtual Handle<Object> Set(Handle<JSObject> holder, uint32_t key,
Igor Sheludko 2015/06/11 14:38:18 Please make it protected.
+ Handle<FixedArrayBase> backing_store,
+ Handle<Object> value) = 0;
+
static ElementsAccessor** elements_accessors_;
const char* name_;
« no previous file with comments | « src/ast.cc ('k') | src/elements.cc » ('j') | src/objects.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698