Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 1172683003: Use the LookupIterator for SetElement and friends (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime-classes.cc ('k') | src/runtime/runtime-literals.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/compiler.h" 9 #include "src/compiler.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 1867 matching lines...) Expand 10 before | Expand all | Expand 10 after
1878 JavaScriptFrameIterator additional_frame_it(isolate, break_frame_id); 1878 JavaScriptFrameIterator additional_frame_it(isolate, break_frame_id);
1879 // If our frame is a top frame and we are stepping, we can do step-in 1879 // If our frame is a top frame and we are stepping, we can do step-in
1880 // at this place. 1880 // at this place.
1881 accept = additional_frame_it.frame()->id() == id; 1881 accept = additional_frame_it.frame()->id() == id;
1882 } 1882 }
1883 } 1883 }
1884 if (accept) { 1884 if (accept) {
1885 if (location.IsStepInLocation()) { 1885 if (location.IsStepInLocation()) {
1886 Smi* position_value = Smi::FromInt(location.position()); 1886 Smi* position_value = Smi::FromInt(location.position());
1887 RETURN_FAILURE_ON_EXCEPTION( 1887 RETURN_FAILURE_ON_EXCEPTION(
1888 isolate, JSObject::SetElement( 1888 isolate,
1889 array, index, Handle<Object>(position_value, isolate), 1889 JSObject::SetElement(array, index, handle(position_value, isolate),
1890 NONE, SLOPPY)); 1890 SLOPPY));
1891 index++; 1891 index++;
1892 } 1892 }
1893 } 1893 }
1894 } 1894 }
1895 return *array; 1895 return *array;
1896 } 1896 }
1897 1897
1898 1898
1899 static const int kScopeDetailsTypeIndex = 0; 1899 static const int kScopeDetailsTypeIndex = 0;
1900 static const int kScopeDetailsObjectIndex = 1; 1900 static const int kScopeDetailsObjectIndex = 1;
(...skipping 1313 matching lines...) Expand 10 before | Expand all | Expand 10 after
3214 return Smi::FromInt(isolate->debug()->is_active()); 3214 return Smi::FromInt(isolate->debug()->is_active());
3215 } 3215 }
3216 3216
3217 3217
3218 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) { 3218 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
3219 UNIMPLEMENTED(); 3219 UNIMPLEMENTED();
3220 return NULL; 3220 return NULL;
3221 } 3221 }
3222 } // namespace internal 3222 } // namespace internal
3223 } // namespace v8 3223 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime-classes.cc ('k') | src/runtime/runtime-literals.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698