Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: src/liveedit.cc

Issue 1172683003: Use the LookupIterator for SetElement and friends (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/liveedit.h ('k') | src/lookup.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 #include "src/v8.h" 6 #include "src/v8.h"
7 7
8 #include "src/liveedit.h" 8 #include "src/liveedit.h"
9 9
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 10 matching lines...) Expand all
21 21
22 namespace v8 { 22 namespace v8 {
23 namespace internal { 23 namespace internal {
24 24
25 void SetElementSloppy(Handle<JSObject> object, 25 void SetElementSloppy(Handle<JSObject> object,
26 uint32_t index, 26 uint32_t index,
27 Handle<Object> value) { 27 Handle<Object> value) {
28 // Ignore return value from SetElement. It can only be a failure if there 28 // Ignore return value from SetElement. It can only be a failure if there
29 // are element setters causing exceptions and the debugger context has none 29 // are element setters causing exceptions and the debugger context has none
30 // of these. 30 // of these.
31 JSObject::SetElement(object, index, value, NONE, SLOPPY).Assert(); 31 JSObject::SetElement(object, index, value, SLOPPY).Assert();
32 } 32 }
33 33
34 34
35 // A simple implementation of dynamic programming algorithm. It solves 35 // A simple implementation of dynamic programming algorithm. It solves
36 // the problem of finding the difference of 2 arrays. It uses a table of results 36 // the problem of finding the difference of 2 arrays. It uses a table of results
37 // of subproblems. Each cell contains a number together with 2-bit flag 37 // of subproblems. Each cell contains a number together with 2-bit flag
38 // that helps building the chunk list. 38 // that helps building the chunk list.
39 class Differencer { 39 class Differencer {
40 public: 40 public:
41 explicit Differencer(Comparator::Input* input) 41 explicit Differencer(Comparator::Input* input)
(...skipping 2013 matching lines...) Expand 10 before | Expand all | Expand 10 after
2055 isolate_->active_function_info_listener()->FunctionCode(code); 2055 isolate_->active_function_info_listener()->FunctionCode(code);
2056 } 2056 }
2057 2057
2058 2058
2059 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) { 2059 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) {
2060 return isolate->active_function_info_listener() != NULL; 2060 return isolate->active_function_info_listener() != NULL;
2061 } 2061 }
2062 2062
2063 } // namespace internal 2063 } // namespace internal
2064 } // namespace v8 2064 } // namespace v8
OLDNEW
« no previous file with comments | « src/liveedit.h ('k') | src/lookup.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698