Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: src/ic/ic.cc

Issue 1172683003: Use the LookupIterator for SetElement and friends (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/harmony-array.js ('k') | src/json-parser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 1462 matching lines...) Expand 10 before | Expand all | Expand 10 after
1473 uint32_t index; 1473 uint32_t index;
1474 if (name->AsArrayIndex(&index)) { 1474 if (name->AsArrayIndex(&index)) {
1475 // Ignore other stores where the receiver is not a JSObject. 1475 // Ignore other stores where the receiver is not a JSObject.
1476 // TODO(1475): Must check prototype chains of object wrappers. 1476 // TODO(1475): Must check prototype chains of object wrappers.
1477 if (!object->IsJSObject()) return value; 1477 if (!object->IsJSObject()) return value;
1478 Handle<JSObject> receiver = Handle<JSObject>::cast(object); 1478 Handle<JSObject> receiver = Handle<JSObject>::cast(object);
1479 1479
1480 Handle<Object> result; 1480 Handle<Object> result;
1481 ASSIGN_RETURN_ON_EXCEPTION( 1481 ASSIGN_RETURN_ON_EXCEPTION(
1482 isolate(), result, 1482 isolate(), result,
1483 JSObject::SetElement(receiver, index, value, NONE, language_mode()), 1483 JSObject::SetElement(receiver, index, value, language_mode()), Object);
1484 Object);
1485 return value; 1484 return value;
1486 } 1485 }
1487 1486
1488 // Observed objects are always modified through the runtime. 1487 // Observed objects are always modified through the runtime.
1489 if (object->IsHeapObject() && 1488 if (object->IsHeapObject() &&
1490 Handle<HeapObject>::cast(object)->map()->is_observed()) { 1489 Handle<HeapObject>::cast(object)->map()->is_observed()) {
1491 Handle<Object> result; 1490 Handle<Object> result;
1492 ASSIGN_RETURN_ON_EXCEPTION( 1491 ASSIGN_RETURN_ON_EXCEPTION(
1493 isolate(), result, 1492 isolate(), result,
1494 Object::SetProperty(object, name, value, language_mode(), store_mode), 1493 Object::SetProperty(object, name, value, language_mode(), store_mode),
(...skipping 1402 matching lines...) Expand 10 before | Expand all | Expand 10 after
2897 static const Address IC_utilities[] = { 2896 static const Address IC_utilities[] = {
2898 #define ADDR(name) FUNCTION_ADDR(name), 2897 #define ADDR(name) FUNCTION_ADDR(name),
2899 IC_UTIL_LIST(ADDR) NULL 2898 IC_UTIL_LIST(ADDR) NULL
2900 #undef ADDR 2899 #undef ADDR
2901 }; 2900 };
2902 2901
2903 2902
2904 Address IC::AddressFromUtilityId(IC::UtilityId id) { return IC_utilities[id]; } 2903 Address IC::AddressFromUtilityId(IC::UtilityId id) { return IC_utilities[id]; }
2905 } // namespace internal 2904 } // namespace internal
2906 } // namespace v8 2905 } // namespace v8
OLDNEW
« no previous file with comments | « src/harmony-array.js ('k') | src/json-parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698