[CSS Grid Layout] Refactor grid-template-areas-get-set.html test

[CSS Grid Layout] Refactor grid-template-areas-get-set.html test

As suggested in https://codereview.chromium.org/1160273004/#msg4
this patch is refactoring
fast/css-grid-layout/grid-template-areas-get-set.html test.

It adds some helper functions to avoid code duplication.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196864

[Manuel Rego, 2015-06-09 14:00:42]

rego@igalia.com changed reviewers:
+ dsinclair@chromium.org, jchaffraix@chromium.org, svillar@igalia.com

[Julien - ping for review, 2015-06-09 20:42:47]

I am not convinced the new code is an improvement (the functions are one-liners)
but I won't hold the change on that as it's small. lgtm

[svillar, 2015-06-10 07:22:37]

https://codereview.chromium.org/1172683002/diff/1/LayoutTests/fast/css-grid-l...
File LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html (right):

https://codereview.chromium.org/1172683002/diff/1/LayoutTests/fast/css-grid-l...
LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html:137:
testGridTemplateAreas("gridWithVerticalRectangle", '"a a" "a a" "a a"');
I think these changes are great but...

https://codereview.chromium.org/1172683002/diff/1/LayoutTests/fast/css-grid-l...
LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html:192:
testJSGridTemplateAreas(element, "none");
... these ones do not improve the tests, I agree it's better to keep the old
code which is more explicit.

[Manuel Rego, 2015-06-10 11:56:47]

Thanks for the reviews.

I'll just keep the changes in the CSS part.

https://codereview.chromium.org/1172683002/diff/1/LayoutTests/fast/css-grid-l...
File LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html (right):

https://codereview.chromium.org/1172683002/diff/1/LayoutTests/fast/css-grid-l...
LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html:192:
testJSGridTemplateAreas(element, "none");
On 2015/06/10 07:22:37, svillar wrote:
> ... these ones do not improve the tests, I agree it's better to keep the old
> code which is more explicit.

Acknowledged.

[Manuel Rego, 2015-06-10 11:56:55]

The CQ bit was checked by rego@igalia.com

[Manuel Rego, 2015-06-10 11:56:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
jchaffraix@chromium.org
Link to the patchset: https://codereview.chromium.org/1172683002/#ps20001
(title: "Patch for landing")

[commit-bot: I haz the power, 2015-06-10 11:57:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1172683002/20001

[commit-bot: I haz the power, 2015-06-10 13:01:32]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196864