Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: Source/devtools/front_end/ui/Widget.js

Issue 1172643002: DevTools: migrate sidebar pane's titleElement to use Toolbar. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/ui/Widget.js
diff --git a/Source/devtools/front_end/ui/Widget.js b/Source/devtools/front_end/ui/Widget.js
index 926ee4ce396215ec26c34435d6dd24b4c1affeb9..87100a7eeebb67a55c9f27c55b4e09866ef0a294 100644
--- a/Source/devtools/front_end/ui/Widget.js
+++ b/Source/devtools/front_end/ui/Widget.js
@@ -251,7 +251,7 @@ WebInspector.Widget.prototype = {
if (this._parentIsShowing())
this._processWillShow();
- this.element.classList.add("visible");
+ this.element.classList.remove("hidden");
dgozman 2015/06/09 13:27:02 Won't this detach iframes?
pfeldman 2015/06/09 13:40:59 Nope, it is alright.
// Reparent
if (this.element.parentElement !== parentElement) {
@@ -284,7 +284,7 @@ WebInspector.Widget.prototype = {
this._processWillHide();
if (!overrideHideOnDetach && this._shouldHideOnDetach()) {
- this.element.classList.remove("visible");
+ this.element.classList.add("hidden");
this._visible = false;
if (this._parentIsShowing())
this._processWasHidden();

Powered by Google App Engine
This is Rietveld 408576698