Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Unified Diff: Source/devtools/front_end/sources/CallStackSidebarPane.js

Issue 1172643002: DevTools: migrate sidebar pane's titleElement to use Toolbar. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: only using latin1 in css Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sources/CallStackSidebarPane.js
diff --git a/Source/devtools/front_end/sources/CallStackSidebarPane.js b/Source/devtools/front_end/sources/CallStackSidebarPane.js
index 52945e0f64b8b91d2a04db0c675e95186975ed67..9866520943997d4c9f1e5192271d6bb115af4a70 100644
--- a/Source/devtools/front_end/sources/CallStackSidebarPane.js
+++ b/Source/devtools/front_end/sources/CallStackSidebarPane.js
@@ -30,14 +30,11 @@
WebInspector.CallStackSidebarPane = function()
{
WebInspector.SidebarPane.call(this, WebInspector.UIString("Call Stack"));
- this.bodyElement.addEventListener("keydown", this._keyDown.bind(this), true);
- this.bodyElement.tabIndex = 0;
+ this.element.addEventListener("keydown", this._keyDown.bind(this), true);
+ this.element.tabIndex = 0;
this.callFrameList = new WebInspector.UIList();
- this.callFrameList.show(this.bodyElement);
+ this.callFrameList.show(this.element);
- var asyncCheckbox = this.titleElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Async"), WebInspector.moduleSetting("enableAsyncStackTraces"), true, WebInspector.UIString("Capture async stack traces")));
- asyncCheckbox.classList.add("scripts-callstack-async");
- asyncCheckbox.addEventListener("click", consumeEvent, false);
WebInspector.moduleSetting("enableAsyncStackTraces").addChangeListener(this._asyncStackTracesStateChanged, this);
WebInspector.moduleSetting("skipStackFramesPattern").addChangeListener(this._blackboxingStateChanged, this);
}
@@ -56,15 +53,15 @@ WebInspector.CallStackSidebarPane.prototype = {
{
this.callFrameList.detach();
this.callFrameList.clear();
- this.bodyElement.removeChildren();
+ this.element.removeChildren();
if (!details) {
- var infoElement = this.bodyElement.createChild("div", "callstack-info");
+ var infoElement = this.element.createChild("div", "callstack-info");
infoElement.textContent = WebInspector.UIString("Not Paused");
return;
}
- this.callFrameList.show(this.bodyElement);
+ this.callFrameList.show(this.element);
this._debuggerModel = details.debuggerModel;
var callFrames = details.callFrames;
var asyncStackTrace = details.asyncStackTrace;
@@ -99,7 +96,7 @@ WebInspector.CallStackSidebarPane.prototype = {
var showAllLink = element.createChild("span", "link");
showAllLink.textContent = WebInspector.UIString("Show");
showAllLink.addEventListener("click", this._revealHiddenCallFrames.bind(this), false);
- this.bodyElement.insertBefore(element, this.bodyElement.firstChild);
+ this.element.insertBefore(element, this.element.firstChild);
this._hiddenCallFramesMessageElement = element;
}
},
@@ -391,7 +388,7 @@ WebInspector.CallStackSidebarPane.prototype = {
setStatus: function(status)
{
if (!this._statusMessageElement)
- this._statusMessageElement = this.bodyElement.createChild("div", "callstack-info status");
+ this._statusMessageElement = this.element.createChild("div", "callstack-info status");
if (typeof status === "string") {
this._statusMessageElement.textContent = status;
} else {

Powered by Google App Engine
This is Rietveld 408576698