Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1356)

Unified Diff: Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

Issue 1172643002: DevTools: migrate sidebar pane's titleElement to use Toolbar. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: only using latin1 in css Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
diff --git a/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js b/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
index 2b35762929714f08b2f0e08664a23a1be2ced8bf..378f2f10ce67b5fc1b394460ccdc6a050cc3c8ad 100644
--- a/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
+++ b/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
@@ -223,10 +223,7 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
element._type = type;
element.addEventListener("contextmenu", this._contextMenu.bind(this, node, type), true);
- var checkboxElement = createElement("input");
- checkboxElement.className = "checkbox-elem";
- checkboxElement.type = "checkbox";
- checkboxElement.checked = enabled;
+ var checkboxElement = createCheckboxLabel("", enabled);
checkboxElement.addEventListener("click", this._checkboxClicked.bind(this, node, type), false);
element._checkboxElement = checkboxElement;
element.appendChild(checkboxElement);
@@ -426,16 +423,11 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
*/
WebInspector.DOMBreakpointsSidebarPane.Proxy = function(pane, panel)
{
- WebInspector.Widget.__assert(!pane.titleElement.firstChild, "Cannot create proxy for a sidebar pane with a toolbar");
-
WebInspector.SidebarPane.call(this, pane.title());
this.registerRequiredCSS("components/breakpointsList.css");
this._wrappedPane = pane;
this._panel = panel;
-
- this.bodyElement.remove();
- this.bodyElement = this._wrappedPane.bodyElement;
}
WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype = {
@@ -460,8 +452,8 @@ WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype = {
_reattachBody: function()
{
- if (this.bodyElement.parentNode !== this.element)
- this.element.appendChild(this.bodyElement);
+ if (this._wrappedPane.element.parentNode !== this.element)
+ this._wrappedPane.show(this.element);
},
__proto__: WebInspector.SidebarPane.prototype

Powered by Google App Engine
This is Rietveld 408576698